feat(relay): gate REQ/COUNT/NEG-OPEN for configured kinds behind NIP-42 AUTH#229
Open
Thunder-Blaze wants to merge 2 commits into
Open
feat(relay): gate REQ/COUNT/NEG-OPEN for configured kinds behind NIP-42 AUTH#229Thunder-Blaze wants to merge 2 commits into
Thunder-Blaze wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Description
Resolves the above Issue by implementing read-side NIP-42 authentication to secure DMs. This addresses current structural limitations where AUTH is exclusively on the write-path and wildcard filters bypass validation.
restrictedReadKinds = ""— zero behavior change for existing operators. Turn it on to lock down DM reads.Key Changes:
relay.auth.restrictedReadKinds(an opt-in list of kinds requiring read AUTH) andrestrictReadToInvolvedPubkey(ensures the authed pubkey is present in the filter'sauthorsor#ptags).Important
Security Enhancements: Closes the omitted-
kindsbypass loophole (wildcard filters are automatically treated as restricted) and strictly "fails closed" (blocks requests) if read-auth is enabled but the auth service is unconfigured.Config
Example of auth config in
strfry.conf:Testing