feat(relay): log client IP address and connection ID on error/validation failures#245
Open
PrarthanaPurohit wants to merge 1 commit into
Open
feat(relay): log client IP address and connection ID on error/validation failures#245PrarthanaPurohit wants to merge 1 commit into
PrarthanaPurohit wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements "log IP address in sendNoticeError and elsewhere where it makes sense".
Currently, when incoming client requests (such as
EVENT,REQ,CLOSE,NEG-OPEN, etc.) fail validation or contain malformed JSON, the relay logs generic messages (e.g.,Rejected invalid event: <reason>) or sendsNOTICEresponses back to the client without logging the client's connection details. This makes debugging misbehaving clients or diagnosing malicious actions difficult for relay operators since they cannot associate these errors with a specific Connection ID or client IP address.This PR prepends client connection details
[connId/ipAddr](rendering the parsed client IP) to console logs across five validation and exception paths insideRelayServer::runIngester:REQ/COUNTQueries (failures to compile filter requests).CLOSEMessage Parses.