Add sortable serial column to studies table#809
Conversation
|
Contaminated with previous commits. |
I think the live pinning functionality got broken by this PR (or has been broken before), as the pinning is only shown after reloading the page. Interesting idea in general. Are stable IDs in dashboards something other tools provide as well or is this giving researchers a specific advantage? I think you already recognize your studies well enough using their name, so I am unsure if this is necessary to include. Moreover, naming the column "ID" does not make it clear what it is supposed to do: Users read that column as an immutable ID, but it behaves like a derived row order, since when deleting study with ID 1, study with ID 2 will replace ID 1, etc. Additionally, it is not purely positional, since IDs don't change with sort/filter/search. I find it more confusing than helpful, so I would not merge it right now. Another contra argument is that for small screens the horizontal space is already limited and the ID column takes away more space. |
|
Thank you for going through the PR. Regarding your feedback:
Let me know your thoughts too please and we will proceed accordingly! |
Summary
This PR adds a serial column to the studies table and makes it sortable.
Changes
Serialcolumn to the studies tableNotes
The serial value is a table-level ordering aid for the studies list.
It is computed from study creation order for the currently visible study set.