Repository navigation
Add opt-in Gemini JSON output to memory experiments - #300
Merged
Merged
Conversation
0thernet
enabled auto-merge (squash)
October 1, 2026 17:45
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
The memory benchmark transport can request JSON output from Gemini with
outputFormat: "json". This sets the provider's JSON MIME option while preserving the existing response, schema and source checks. Omitting the option preserves the previous request and capture bytes; xAI bindings reject the option.Campaign v2/v3 recovery now validates the saved request body and reserved amount when reconstructing a missing local receipt. This prevents a claimed request hash alone from accepting an altered capture.
Contract impact
Adds the benchmark-only request/capture protocol
oh.memory-lab-api-json.v1. JSON requests include 38 extra body bytes in context and cost calculations. The existing request protocol remains unchanged for bindings without the option. Wave plans, journals, locks, spending ledgers, stored Oh data and packaged library interfaces keep their existing formats.Verification
PR CI: https://github.com/hraness/oh/actions/runs/36901753064 — tested merge
cff3a54dcc62b01ef080c565eff215358e2fdb9c, head6abf81bda0457b625a73dea545b0481fe3f6e8db, basea1f67abbebc68999f387c7d40252dfd32509c4e1. Integrated main:290de0c005b047b51c1c99e10d89f5477bd01975, https://github.com/hraness/oh/actions/runs/36902482111. The reviewed head and integrated main have identical Git trees.Tests use invented responses. Live qualification and benchmark results remain separate from this source change.