Repository navigation
test(cli): exercise MCP grant on local retained daemon - #301
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Run the existing MCP grant boundary regression with retained local daemon sockets instead of binding the unrelated public peer listener. Poll readiness with a bounded sleep and startup budget. The test still checks the granted room, denied cross-room/admin requests, no credential/other-room leakage, and rejection after restart.
Checks
cargo +1.98.1 fmt --all -- --check— passed.CARGO_HOME=$PWD/.xcb-cargo-home CARGO_NET_OFFLINE=true cargo +1.98.1 test -p vhalla-cli --bin vhalla --all-features --locked headless::mcp::tests:: -- --nocapture— 12 passed.CARGO_HOME=$PWD/.xcb-cargo-home CARGO_NET_OFFLINE=true cargo +1.98.1 clippy -p vhalla-cli --bin vhalla --all-features --tests --locked -- -D warnings— passed.git diff --cached --check— passed./private/tmpwrites and local Unix socket binds (EPERM). It must pass in the PR's required Linux CLI suite; no headless/live qualification claim is made here.Only
crates/vhalla-cli/src/headless/commands_tests.rsis committed; local Cargo cache and validation log are untouched.