Skip to content

fix(products): follow product open_type strictly on anchor button #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trtajim merged 1 commit into from
Sep 21, 2026
Merged

fix(products): follow product open_type strictly on anchor button #357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 6 additions & 20 deletions resources/js/components/ProductCard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<script setup lang="ts">
import { Link } from '@inertiajs/vue3';
import { ExternalLink, ArrowRight, Users, Layers } from 'lucide-vue-next';
import { ArrowRight, ExternalLink, Layers, Users } from 'lucide-vue-next';
import { computed } from 'vue';

export interface ProductItem {
Expand All @@ -26,11 +25,7 @@ const displayImage = computed(() => {
});

const isBlank = computed(() => {
return (
props.product.open_type === '_blank' ||
props.product.link.startsWith('http://') ||
props.product.link.startsWith('https://')
);
return props.product.open_type === '_blank';
});

const buttonLabel = computed(() => {
Expand Down Expand Up @@ -87,24 +82,15 @@ const buttonLabel = computed(() => {
<!-- Action Button -->
<div class="mt-6 border-t border-slate-100 pt-4 dark:border-gray-800">
<a
v-if="isBlank"
:href="product.link"
target="_blank"
rel="noopener noreferrer"
:target="product.open_type || '_self'"
:rel="isBlank ? 'noopener noreferrer' : undefined"
class="inline-flex w-full items-center justify-center gap-2 rounded-xl bg-indigo-600 px-4 py-2.5 text-sm font-bold text-white shadow-xs transition-all hover:bg-indigo-700 active:scale-98"
>
<span>{{ buttonLabel }}</span>
<ExternalLink class="h-4 w-4" />
<ExternalLink v-if="isBlank" class="h-4 w-4" />
<ArrowRight v-else class="h-4 w-4" />
</a>

<Link
v-else
:href="product.link"
class="inline-flex w-full items-center justify-center gap-2 rounded-xl bg-indigo-600 px-4 py-2.5 text-sm font-bold text-white shadow-xs transition-all hover:bg-indigo-700 active:scale-98"
>
<span>{{ buttonLabel }}</span>
<ArrowRight class="h-4 w-4" />
</Link>
</div>
</div>
</template>
Loading