Skip to content

fix: update google callback failure message #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trtajim merged 1 commit into from
Sep 24, 2026
Merged

fix: update google callback failure message #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/Http/Controllers/AuthController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public function handleGoogleCallback(Request $request)
} catch (\Throwable $e) {
report($e);

return redirect()->route('login')->with('error', 'Failed to authenticate with Google. Please try again.');
return redirect()->route('login')->with('error', 'Failed to authenticate. Refresh the page & try again.');
}

$user = User::where('google_id', $googleUser->getId())
Expand Down
2 changes: 1 addition & 1 deletion tests/Feature/AuthenticationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@
$response = $this->get(route('auth.google.callback'));

$response->assertRedirect(route('login'));
$response->assertSessionHas('error', 'Failed to authenticate with Google. Please try again.');
$response->assertSessionHas('error', 'Failed to authenticate. Refresh the page & try again.');
});

test('google auth redirects to intended url if set for existing user', function () {
Expand Down
Loading