[HSTACK] feat: support custom logical schemas passed through DeltaCon…#9
Open
[HSTACK] feat: support custom logical schemas passed through DeltaCon…#9
Conversation
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds automatic detection for virtual columns — logical fields present in a caller-supplied extended schema that do not exist in the table's physical Parquet files. This is needed when a higher-level engine augments the table schema (e.g. computed or injected columns) and wants to push a single unified schema through the scan layer.
Without this, callers had to strip virtual columns from the schema before handing it to DeltaScanBuilder, or accept a runtime "column not found" error.
DeltaScanBuilder::build() now automatically identifies virtual columns by diffing the caller-supplied config.schema against the table's physical snapshot schema (via read_schema()). Any field that appears in the extended schema but is absent from both the physical schema and the partition columns is treated as virtual:
Concerns: