feat(config): add browserless configs and fetch lane#304
Merged
gildesmarais merged 3 commits intomasterfrom Mar 27, 2026
Merged
feat(config): add browserless configs and fetch lane#304gildesmarais merged 3 commits intomasterfrom
gildesmarais merged 3 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Browserless-backed “fetch lane” to the config test suite, along with a curated set of Browserless-only configs, so live fetch specs can be run selectively depending on environment configuration.
Changes:
- Added 5 new
strategy: browserlessconfigs (Apple Newsroom, DeepMind Blog, Notion Blog, Shopify Blog Latest, Spotify Newsroom). - Introduced
BrowserlessFetchConfigsand updated shared fetch examples to conditionally skip Browserless configs unless Browserless env vars are configured. - Added a dedicated Browserless fetch runner (
bin/rspec_browserless_configs), a Makefile target, and documented fetch lanes in the README.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| spec/support/shared_examples/config.yml_spec.rb | Applies runtime header defaults in fetch specs and skips Browserless-backed fetch tests when env isn’t configured. |
| spec/support/browserless_fetch_configs.rb | Defines the curated Browserless config subset + env gating logic (local websocket exception). |
| spec/browserless_fetch_configs_spec.rb | Tests Browserless env gating behavior (local URLs vs non-local). |
| lib/html2rss/configs/apple.com/newsroom.yml | New Browserless-backed config for Apple Newsroom. |
| lib/html2rss/configs/deepmind.google/blog.yml | New Browserless-backed config for DeepMind Blog. |
| lib/html2rss/configs/notion.com/blog.yml | New Browserless-backed config for Notion Blog. |
| lib/html2rss/configs/shopify.com/blog.yml | New Browserless-backed config for Shopify Blog Latest. |
| lib/html2rss/configs/spotify.com/newsroom.yml | New Browserless-backed config for Spotify Newsroom. |
| bin/rspec_browserless_configs | New script to run only the Browserless-backed fetch subset. |
| README.md | Documents the two fetch lanes and Browserless env requirements. |
| Makefile | Adds test-fetch-browserless-configs and updates test-fetch-all-configs runner. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds support for testing and running Browserless-backed fetch strategies for a subset of configs, improves test configuration, and enhances documentation for these new test lanes. It introduces new config files that use the Browserless strategy, adds logic to selectively run these tests based on environment variables, and provides clear instructions in the README.
Browserless-backed config support:
browserlessstrategy forapple.com/newsroom.yml,deepmind.google/blog.yml,notion.com/blog.yml,shopify.com/blog.yml, andspotify.com/newsroom.yml. [1] [2] [3] [4] [5]BrowserlessFetchConfigsmodule to track which configs require Browserless and to check if the necessary environment variables are set.Test suite enhancements:
spec/browserless_fetch_configs_spec.rbwith tests for the environment-checking logic inBrowserlessFetchConfigs.Build and documentation improvements:
Makefileto addtest-fetch-browserless-configsand refine how fetch tests are run, separating all fetch tests from Browserless-only tests.README.mdwith documentation on how to run the new fetch test lanes, including environment variable requirements and usage instructions.