Skip to content

fix: defects for token/retry/loading UX#924

Merged
gildesmarais merged 3 commits intomainfrom
codex/workstream-b-review-b-ux-defects
Mar 28, 2026
Merged

fix: defects for token/retry/loading UX#924
gildesmarais merged 3 commits intomainfrom
codex/workstream-b-review-b-ux-defects

Conversation

@gildesmarais
Copy link
Copy Markdown
Member

@gildesmarais gildesmarais commented Mar 28, 2026

Summary

  • tighten token rejection detection so non-token forbidden/policy failures do not clear saved token or trigger token-recovery UX
  • only show manual strategy-switch recovery when it is actionable (faraday -> browserless)
  • update converting-state copy to reflect actual behavior: result first, preview after
  • add regression coverage for non-token 403 behavior

Scope

  • Workstream B follow-up only
  • no broad refactors

Validation

  • cd frontend && npm run test:unit -- --run src/tests/App.test.tsx

Notes

  • docs workspace in this environment has no git remote configured, so only the html2rss-web PR is opened here.

@gildesmarais gildesmarais requested a review from Copilot March 28, 2026 10:17
@gildesmarais gildesmarais changed the title fix: Workstream B review defects for token/retry/loading UX fix: defects for token/retry/loading UX Mar 28, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refines the frontend’s error/UX handling around access-token failures and manual retry strategy prompts, aligning UI behavior with actual conversion flow and adding a regression test to prevent token-clearing on non-token 403s.

Changes:

  • Tightens access-token rejection detection and gates token-recovery UX to token-related failures.
  • Shows the manual “Try X instead” strategy-switch action only when switching from faradaybrowserless is actionable.
  • Updates converting-state copy and adds regression coverage for non-token forbidden behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
frontend/src/components/AppPanels.tsx Updates token input field configuration and loading-state copy.
frontend/src/components/App.tsx Refines token error detection and strategy-switch eligibility logic.
frontend/src/__tests__/App.test.tsx Updates copy assertion and adds regression test for non-token forbidden failures.

gildesmarais and others added 2 commits March 28, 2026 11:33
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@gildesmarais gildesmarais merged commit 2d38633 into main Mar 28, 2026
12 checks passed
@gildesmarais gildesmarais deleted the codex/workstream-b-review-b-ux-defects branch March 28, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants