Skip to content

feat: make feed directory search-first and easier to browse#1102

Merged
gildesmarais merged 2 commits intomainfrom
feat/feed-directory-ux
Mar 21, 2026
Merged

feat: make feed directory search-first and easier to browse#1102
gildesmarais merged 2 commits intomainfrom
feat/feed-directory-ux

Conversation

@gildesmarais
Copy link
Copy Markdown
Member

Summary

  • redesign the feed directory so search and ready-to-use feeds appear immediately
  • demote instance selection into supporting context and clarify default parameter handling
  • tighten feed rows around source URLs, copy/rss actions, and mobile scanning

Validation

  • npx prettier --check src/components/FeedDirectory.astro src/components/feed-directory.js src/content/docs/feed-directory/index.mdx
  • npm run build

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Redesigns the Feed Directory documentation page and component to be search-first, with improved instance selection UX and tighter feed rows (source link, RSS action, copy action).

Changes:

  • Replaces most of the MDX page intro with the FeedDirectory component and updated instance/contribution links.
  • Refactors the feed directory client JS: search result/empty state handling, instance URL editor + hash persistence, parameter form toggles, and copy-to-clipboard.
  • Rebuilds the FeedDirectory.astro markup/CSS for the new layout (search header, instance summary/editor, feed rows, and empty state).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
src/content/docs/feed-directory/index.mdx Embeds FeedDirectory and updates surrounding copy/links.
src/components/feed-directory.js Adds instance hash handling, improved search UI state, parameter toggles, and copy-link behavior.
src/components/FeedDirectory.astro New search-first layout + feed row actions and styling.

</section>

<!-- Enhanced functionality with vanilla JavaScript -->
<script src="./feed-directory.js"></script>
Copy link

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<script src="./feed-directory.js"> is a URL relative to the rendered page, but feed-directory.js lives under src/components/ and there is no corresponding file in public/. Unless this script is emitted elsewhere, the browser will likely 404 this request and the directory will lose its JS behavior (search, instance switching, copy). Consider bundling it via Astro/Vite (e.g., import it as a module) or moving it into public/ and referencing it with a stable absolute path.

Suggested change
<script src="./feed-directory.js"></script>
<script src={Astro.resolve('./feed-directory.js')}></script>

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the built output before and after 45105d0. Astro is emitting the component script as a bundled module asset under dist/_astro/FeedDirectory...js, so this relative src is being compiled rather than requested from /feed-directory/feed-directory.js. Leaving this thread open if you want the component switched to an explicit imported pattern anyway.

@gildesmarais gildesmarais marked this pull request as ready for review March 21, 2026 12:50
@gildesmarais gildesmarais merged commit 14def02 into main Mar 21, 2026
4 checks passed
@gildesmarais gildesmarais deleted the feat/feed-directory-ux branch March 21, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants