Fix Network_Container::site_exists() querying wrong database table#1312
Open
jbrejcha wants to merge 14 commits intohtmlburger:developmentfrom
Open
Fix Network_Container::site_exists() querying wrong database table#1312jbrejcha wants to merge 14 commits intohtmlburger:developmentfrom
jbrejcha wants to merge 14 commits intohtmlburger:developmentfrom
Conversation
get_blog_status() expects a blog_id from wp_blogs, but site_exists() receives a network site_id from wp_site. Query wp_site directly instead. Fixes htmlburger#1304
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_blog_status()expects ablog_idfrom thewp_blogstable, butsite_exists()receives a networksite_idfromwp_site. This causes valid network IDs to fail validation when they do not match any blog ID.Fix queries
wp_sitedirectly.Fixes #1304