Skip to content

Fix option parsing after request arguments on older Python #1849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mturac wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix option parsing after request arguments on older Python #1849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ebdd60
Fix intermixed options on older Python
mturac May 17, 2026
f6e0f1c
Preserve parser behavior for trailing request items
mturac May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions httpie/cli/argparser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,20 @@ def parse_args(
self.env = env
self.env.args = namespace = namespace or argparse.Namespace()
self.args, no_options = super().parse_known_args(args, namespace)
if self.args.url:
request_items = [
option for option in no_options if not option.startswith('-')
]
if request_items:
request_item_type = KeyValueArgType(*SEPARATOR_GROUP_ALL_ITEMS)
self.args.request_items = [
*(self.args.request_items or []),
*(request_item_type(item) for item in request_items),
]
no_options = [
option for option in no_options
if option.startswith('-')
]
if self.args.debug:
self.args.traceback = True
self.has_stdin_data = (
Expand Down
17 changes: 17 additions & 0 deletions tests/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,23 @@ def test_multiple_text_fields_with_same_field_name(self):
]


class TestIntermixedOptions:
def test_output_option_after_url_keeps_request_items(self):
r = http(
'--offline',
'--ignore-stdin',
'post',
'pie.dev/post',
'-v',
'header1:xyz',
'x=1',
)

assert r.exit_status == ExitStatus.SUCCESS
assert 'header1: xyz' in r
assert '"x": "1"' in r


class TestQuerystring:
def test_query_string_params_in_url(self, httpbin):
r = http('--print=Hhb', 'GET', httpbin + '/get?a=1&b=2')
Expand Down
Loading