Repository navigation
feat(mcp): Add keyword discovery and targeting audits - #89
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
git diff --check origin/main...HEAD(plus staged/working-tree checks when applicable)768 tests in 62 suites pass locally, including native/sparse/fallback competition evidence, removal scope and same-day re-addition, legacy JSON compatibility, MCP round trips, and transport cancellation without refresh failures.
An isolated stdio smoke check registers all 42 tools, adds fixture tracks, and verifies scoped untracking and idempotent retries. The GUI smoke check verifies the Stop control and re-enabled Refresh action. Production data and live App Store metadata remain unchanged.
Earlier live validation covers saved Apple Ads access, both popularity sources, and seeded/paged keyword discovery. The prior production-credential metadata smoke attempt remains unverified after a Keychain approval timeout. This review also probes ASC keyword/phrase suggestions read-only: phrase access fails or yields no candidates, so phrase support remains outside the release.
The optional dormant
OpenASOMCPscheme build remains unverified locally: after disk cleanup, Xcode package dependency scanning fails to resolve CNIOLLHTTP/CNIOExtrasZlib in EventSource. The distributed app-based stdio path is covered by the passing smoke check.A clean rebuild of the final committed source also passes all 768 tests after resetting the local build cache.
The skill validator and staged/working-tree diff checks pass. The branch integrates #87 and #88 before testing.
Review State
Source and Credit
Uses the existing official Apple Ads Swift SDK and App Store Connect metadata documentation.
Feature research credits heondo's keyword untracking, refresh Stop control, and nicremo's competition/market tooling. Implementation uses OpenASO's current storage and retained estimator rather than importing an older fork stack. The repository includes cited findings for all 29 forks and ASC CLI 5.17.0.