Repository navigation
fix(release): Publish Sparkle delta files - #90
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upload generated Sparkle delta files to R2 before publishing the appcast that references them. Keep existing DMG, release-note, and stable-download handling.
The 0.4.6 feed advertised five delta URLs that returned 404 because the workflow uploaded only the DMG and notes. The live feed now safely uses the signed full DMG; this fix preserves working delta updates for future releases.
Validation
git diff --check origin/main...HEAD(plus staged/working-tree checks when applicable)actionlint -shellcheck= -pyflakes= .github/workflows/release.ymlpasses. YAML parses andbash -npasses all 21 run steps. A credentialed R2aws s3 sync --dryrunconfirms the filter selects only.deltafiles and excludes DMGs and Markdown.The unchanged app passes 768 tests locally, CI, and the signed release workflow. Public 0.4.6 DMG hash, code signature, notarization ticket, stable URL, and repaired feed are verified. No application code changes in this PR.
Review State
Source and Credit
Independent repair found during 0.4.6 release verification, using the existing R2 credentials and publishing layout. Filter behavior follows the AWS CLI sync contract.