fix: correct AttributeError in TangentialCFG and NameError in FrequencyDecoupledGuidance#13434
Open
Ricardo-M-L wants to merge 1 commit intohuggingface:mainfrom
Open
Conversation
…in FrequencyDecoupledGuidance Fix two bugs in the guiders module: 1. TangentialClassifierFreeGuidance.is_conditional references `self._num_outputs_prepared` which does not exist. All other guiders use `self._count_prepared` (defined in BaseGuidance). This causes an AttributeError whenever is_conditional is accessed. 2. FrequencyDecoupledGuidance.forward uses `pred_cond_freq` in the else branch (line 278) where FDG is disabled for a level, but that variable is only defined inside the if branch. If the first pyramid level has FDG disabled, this raises a NameError. Even when a prior level defined it, the wrong level's data would be used. Fixed to use `pred_cond_pyramid[level]` which correctly indexes the pyramid. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two functional bugs in the experimental guiders module, both introduced in #11311 (Modular Diffusers Guiders):
Bug 1:
TangentialClassifierFreeGuidance.is_conditional— AttributeErrorThe
is_conditionalproperty referencesself._num_outputs_prepared, which does not exist on the class or its base classBaseGuidance. Every other guider usesself._count_prepared(defined and managed byBaseGuidance). Accessingis_conditionalon aTangentialClassifierFreeGuidanceinstance raises:Fix: Replace
self._num_outputs_preparedwithself._count_prepared.Bug 2:
FrequencyDecoupledGuidance.forward— NameError / wrong pyramid levelIn the
forwardmethod's loop over pyramid levels, theelsebranch (when FDG is disabled for a level) appendspred_cond_freqto the guided pyramid. However,pred_cond_freqis only assigned inside theifbranch. This causes:Fix: Replace
pred_cond_freqwithpred_cond_pyramid[level]to correctly reference the current level's conditional prediction.Test plan
_num_outputs_preparedis not defined anywhere in the codebase;_count_preparedis the correct attribute used by all other guiderspred_cond_freqis only assigned inside theifbranch, confirming theelsebranch will fail or use stale data🤖 Generated with Claude Code