Fix Qwen Image DreamBooth prior-preservation batch ordering#13441
Open
azolotenkov wants to merge 1 commit intohuggingface:mainfrom
Open
Fix Qwen Image DreamBooth prior-preservation batch ordering#13441azolotenkov wants to merge 1 commit intohuggingface:mainfrom
azolotenkov wants to merge 1 commit intohuggingface:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the prior-preservation batching issue in the Qwen Image DreamBooth LoRA script.
PR #13396 corrected the repeat count under
--with_prior_preservation, but the script still repeats prompt embeddings withrepeat(...), which interleaves the batch as[inst, class, inst, class, ...]. The dataloader and latertorch.chunk(..., 2, dim=0)logic assume grouped ordering[inst1..instB, class1..classB].In addition,
weightingwas not chunked alongsidemodel_predandtarget, which causes a batch mismatch fortrain_batch_size > 1.This update:
repeat_interleave(..., dim=0)forprompt_embedsandprompt_embeds_maskweightingin the prior-preservation loss pathReproduction:
This fails with:
RuntimeError: The size of tensor a (4) must match the size of tensor b (2)Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@sayakpaul