Fix Cosmos2 safety checker grad mode leak#13799
Open
ooovenenoso wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #13790.
Cosmos2VideoToWorldPipelinecreates a defaultCosmosSafetyCheckerwhensafety_checker=None. If the guardrail dependency changes PyTorch's global grad mode during construction, that state leaks out offrom_pretrained()and leavestorch.is_grad_enabled()disabled globally.This preserves and restores the caller's grad mode around default safety checker construction.
Before submitting
Who can review?
@DN6
Tests
test_default_safety_checker_preserves_grad_modeto cover default safety checker construction that disables grad mode.AssertionError: False is not true.python -m pytest tests/pipelines/cosmos/test_cosmos2_video2world.py::Cosmos2VideoToWorldPipelineFastTests::test_default_safety_checker_preserves_grad_mode -qpython -m pytest tests/pipelines/cosmos/test_cosmos2_video2world.py -qmake stylemake quality