[fix] hooks/taylorseer_cache: fix off-by-one in post-warmup compute interval#13806
Open
Dev-X25874 wants to merge 2 commits into
Open
[fix] hooks/taylorseer_cache: fix off-by-one in post-warmup compute interval#13806Dev-X25874 wants to merge 2 commits into
Dev-X25874 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an off-by-one error in
TaylorSeerCacheHook._measure_should_computethat caused the first post-warmup denoising step to always use a cached
prediction instead of performing a fresh forward pass.
Root cause: The interval formula contained a spurious
- 1:In Python,
-1 % cache_intervaliscache_interval - 1(never zero), sothe step at
current_step == disable_cache_before_step— which is documentedas the first step where caching begins — was always routed to
state.predict()rather than a real forward pass. This shifted the entire post-warmup compute
cadence by one step throughout inference.
Concrete example with
disable_cache_before_step=3, cache_interval=5:A new test file
tests/hooks/test_taylorseer_cache.pyis added that directlyexercises
_measure_should_computestep-by-step and will fail on the originalcode at step 3.
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@sayakpaul