Repository navigation
Conversation
yiyixuxu
marked this pull request as draft
August 17, 2026 21:18
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
yiyixuxu
marked this pull request as ready for review
October 22, 2026 09:13
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…ed, unit test and guide note Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
yiyixuxu
force-pushed
the
required-input-no-default
branch
from
October 22, 2026 16:52
9cc14db to
a73e967
Compare
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Chessing234
suggested changes
Oct 23, 2026
Chessing234
left a comment
There was a problem hiding this comment.
the pitfalls list in .ai/references/modular.md numbers two items as 10. the torch.randn note never moved to 11, so the helpers note is 11 instead of 12.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14388, see the issue for more details on the bug.
This PR:
When an
InputParamis bothrequired=Trueand carries a non-Nonedefault:InputParam.__post_init__now keeps the default, treats the input as optional and logs a warning. This matches what the code has always done at runtime, so no pipeline changes behavior. The usual way to hit this isInputParam.template("num_inference_steps", required=True): when the user try to reuse the template for its type hint and description, but want to mark it as required.Go through every input in the library that was declared both ways and decide explicitly which one it means:
num_inference_steps:Cosmos3SetTimestepsStep,Cosmos3TransferSetTimestepsStep,MiniMaxH3SetTimestepsSteprequired=True, default=None, since by then the value is always in the state:Cosmos3DenoiseLoopWrapper,Krea2LoopDenoiser,Krea2DenoiseLoopWrapper,LTXLoopDenoiser,LTXImage2VideoLoopDenoiser,LTXDenoiseLoopWrapper,LTX2LoopDenoiser,LTX2DenoiseLoopWrapper,QwenImageDenoiseLoopWrapper,QwenImage21DenoiseLoopWrapperdtype(LTX, LTX-2) andbatch_size(LTX):required=True, default=None. They are intermediates always produced upstream, so the default was never used.Also re-generated the auto docstrings and added a gotcha for the modular tests: I noticed the MiniMax-H3 workflow test explicitly listed
num_inference_stepsas a required input. That test is meant to be a snapshot of the pipeline's contract (components, configs, inputs with their defaults) so deviations like this get caught, which only works if the table is read back against the other pipelines rather than copied from the code.