Repository navigation
[MiniMax-H3] Add opt-in process-group tiled VAE decoding - #15063
Draft
LeslieWylie wants to merge 1 commit into
Draft
LeslieWylie wants to merge 1 commit into
LeslieWylie wants to merge 1 commit into
Conversation
Decode original tiles across an explicit process group and restore the original tile order before temporal and spatial blending. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: LeslieWylie <112309453+LeslieWylie@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add optional process-group tile decoding to
AutoencoderKLMiniMaxH3. Pass an initialized group to the existingenable_tiling(process_group=...)API; each rank decodes a share of the original spatial tiles and receives the full result. Default decoding and encoding stay local, and temporal chunks, tile geometry, and blending stay unchanged.This is a draft pending real CUDA/NCCL and performance validation. No isolated VAE speedup or full-pipeline quality improvement is claimed.
Validation
On current main
d42ebf9c6e0b46103b74283f5324357a67acaa04, using PyTorch 2.14 CPU and Gloo:git diff --checkpass.These are CPU correctness checks, not current-main GPU or pretrained-checkpoint validation. Real NCCL execution, standalone decode timing, and full-resolution output comparison remain pending. Distributed decoding is inference-only and outside a full-graph compiled region.
Related work and self-review
#12590 proposes parallel tiling for AutoencoderKL/Wan; it does not modify the H3 VAE. This draft stays within H3's existing tile/chunk/blend implementation and adds no generic parallel framework. Searches for H3 VAE and
AutoencoderKLMiniMaxH3parallel decoding found no matching open PR. No maintainer acknowledgment for this API has been obtained.Self-review: READY for draft review. No blocking correctness or dead-code findings remain after tracing
decode → _decode → _decode_clip → _stitch_tilesand checking the public opt-in call in the added test. Subgroup source ranks are mapped to global ranks and allocation metadata uses the actual decoder output dtype. Remaining review items are API alignment with related parallel-tiling work, real NCCL validation, and performance evidence. AI assistance was used for implementation, checks, and this description; no submitting-human test execution is claimed.Before submitting
self-reviewskill on the diff?Who can review?
Community review of the optional API and its relationship to existing parallel-tiling work is welcome.