Repository navigation
Deprecate output_type="latent" in modular decoders - #15078
dhvani7014 wants to merge 4 commits into
Conversation
|
Hi @yiyixuxu, could you please review this PR whenever you get a chance? I'd really appreciate your feedback. Thank you! |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
yiyixuxu
left a comment
There was a problem hiding this comment.
thanks!
i left a comment
573e0bc to
0207a8c
Compare
|
Hi @yiyixuxu, just a gentle ping on this one when you have time. I switched to the deprecation as you suggested. Let me know if anything else needs changing! |
|
Thanks @yiyixuxu! Updated the deprecation message, removed the extra output_type check (kept just the deprecate in all the decoders), and added a line in echo.md on getting the denormalized VAE tensors without decoding. |
| without decoding, run the pipeline without the decode step and denormalize these with `latents_mean`, `latents_std` | ||
| and `vae_scaling_factor` for video, or `audio_latents_mean` and `audio_latents_std` for audio. |
There was a problem hiding this comment.
| without decoding, run the pipeline without the decode step and denormalize these with `latents_mean`, `latents_std` | |
| and `vae_scaling_factor` for video, or `audio_latents_mean` and `audio_latents_std` for audio. | |
| without decoding, run the pipeline without the decode step. |
What does this PR do?
Fixes #15071
Deprecates the
output_type == "latent"branches in the modular decode blocks for flux, sd3, sdxl, cosmos and echo, targeting removal in 0.47.0 alongside the packed-latents deprecation from #14737. Latents are available viaoutput="latents"instead. ltx2 is left for #14612.Self-review notes
output_type="latent"to these decoders still returns the latents as before, but now emits aFutureWarning(viadeprecate, 0.47.0) pointing tooutput="latents".output_typenot in ("pil", "np", "pt") raises a ValueError, same as minimax_h3.output_type="pt". Added a flux test that checks the deprecation warning and that the latents come back unchanged.test_to_devicefailures also fail on main on my Mac (MPS), so they're unrelated.Before submitting
self-reviewskill on the diff?output_type="latent"from modular decode blocks聽#15071Who can review?
@yiyixuxu