Repository navigation
Fix: filter Cosmos3 warnings for auxiliary FP8 export scales - #15107
yzhautouskay wants to merge 2 commits into
Conversation
|
Hi @yzhautouskay, thanks for the PR! It does not appear to link an issue it fixes. If this PR addresses an existing issue, please add a closing keyword (e.g. Please note that PRs without a linked issue are likely to be automatically closed 10 days after this notice. Once the PR links an issue (or gets the |
|
@yzhautouskay
|
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
|
||
| class TestCosmos3OmniTransformerModel(Cosmos3OmniTransformerTesterConfig, ModelTesterMixin): | ||
| @pytest.mark.parametrize("include_unexpected_weight", [False, True]) | ||
| def test_load_ignores_export_scales(self, tmp_path, include_unexpected_weight): |
There was a problem hiding this comment.
ohh i think we don't need the test this per model
cc @sayakpaul, do we want to add a generic test for this instead?
There was a problem hiding this comment.
@yzhautouskay I think let's wait for #15140 so that you could rebase it in your PR and this PR will then just be about the src/diffusers/models/transformers/transformer_cosmos3.py change?
What does this PR do?
Ignore the auxiliary
input_scaleandweight_scalekeys exported for vLLM-Omni/SGLang when loading Cosmos3 in Diffusers. Preserve warnings for unrelated unexpected weights and add regression coverageBefore submitting
self-reviewskill on the diff?documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.