[chore] catch styling bugs in the prs better.#321
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
kernels/tests/test_kernel_card.py
Outdated
| build_toml = kernel_dir / "build.toml" | ||
| build_toml.write_text( | ||
| """[general] | ||
| build_toml.write_text("""[general] |
There was a problem hiding this comment.
Result of make style.
We could consider fixing the black version (same for isort and ruff) but I don't think it's a big deal.
|
Doesn't look like we have |
|
@danieldk a friendly ping on this one as well. |
| uv run black --check kernels | ||
| run: uv run --with black black --check kernels/src kernels/tests | ||
|
|
||
| validate-dependencies: |
There was a problem hiding this comment.
The dependency validation gets removed?
There was a problem hiding this comment.
I removed it because update_python_depends.py (the script this step uses) is missing.
There was a problem hiding this comment.
Ah, right. But we should still check that the files are the same in the Rust crate and the Python packages (ideally we'd only have one file, but both don't deal well with out-of-tree files).
There was a problem hiding this comment.
I think something like cmp -s file1 file2 should do the trick, since it returns exit code != 0 when the files differ.
There was a problem hiding this comment.
Do the latest changes work for you? 👀
3 participants
Currently, our CI doesn't properly catch the styling issues despite having the
lint.ymlworkflow. This PR fixes that.Additionally, this PR:
qualitycommand in theMakefile. So, when developers runmake style && make quality, they know that the CI will be through with this.test_kernels.ymlworkflow.