Open
Conversation
- RMSNorm, RoPE 3D, GEGLU, AdaLN kernel patterns - Benchmark scripts (micro + e2e for LTX-Video) - HuggingFace Kernels integration example - Reference docs: optimization guides, templates, troubleshooting
Member
|
Cc: @burtenshaw @danieldk |
Contributor
|
Really cool PR! Could you please share a trace with a coding harness like claude code, codex, or opencode. |
sayakpaul
approved these changes
Mar 24, 2026
Member
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
Thanks for this 🔥
I will let @burtenshaw do the final approval. Some comments:
- https://huggingface.co/docs/kernels/main/en/cli-skills should be likely modified to mention that ROCm kernels are also supported.
- Could we also see some numbers with and without these kernels, and preferably some videos?
| @@ -0,0 +1,252 @@ | |||
| # Diffusers Pipeline Integration Guide (ROCm) | |||
|
|
|||
| Integrating custom Triton kernels into HuggingFace diffusers pipelines on AMD GPUs. | |||
Member
There was a problem hiding this comment.
Should we also enlist any dependencies?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ROCm Triton kernels skill for MI355X/R9700