Fix type_ids not applied to overflow encodings#1965
Open
joaquinhuigomez wants to merge 1 commit intohuggingface:mainfrom
Open
Fix type_ids not applied to overflow encodings#1965joaquinhuigomez wants to merge 1 commit intohuggingface:mainfrom
joaquinhuigomez wants to merge 1 commit intohuggingface:mainfrom
Conversation
…and RobertaProcessing Fixes huggingface#1908. When a Piece is a Sequence with overflows, set_type_ids and set_sequence_id were only called on the main encoding, leaving overflow encodings with incorrect (default) type_ids. This applies the same type_id and sequence_id to all overflow encodings in: - TemplateProcessing::apply_template - RobertaProcessing::process_encodings - PostProcessor::process (default trait impl) Adds a regression test that explicitly validates type_ids on overflow and nested overflow encodings.
joaquinhuigomez
force-pushed
the
fix/overflow-type-ids
branch
from
d2a3067 to
19b9b7a
Compare
Author
|
Hi — just checking if this is still on the review queue. Happy to address any feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using TemplateProcessing with type_id mappings, type_ids were only applied to the main encoding but not to overflow encodings from truncation. This fix iterates over overflow encodings in apply_template and sets both type_ids and sequence_ids consistently.