Skip to content

feat: add async decode batch type annotations in decoding#1966

Merged
ArthurZucker merged 1 commit intohuggingface:mainfrom
michaelfeil:mf/async-decode-batch
Mar 26, 2026
Merged

feat: add async decode batch type annotations in decoding#1966
ArthurZucker merged 1 commit intohuggingface:mainfrom
michaelfeil:mf/async-decode-batch

Conversation

@michaelfeil
Copy link
Copy Markdown
Contributor

@michaelfeil michaelfeil commented Mar 19, 2026

Something I forgot to add to #1843.
Reminder to myself to also wire up native asynchronous support.

@michaelfeil
Copy link
Copy Markdown
Contributor Author

@ArthurZucker this should be an easy one to review. TY.

Copy link
Copy Markdown
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah sure, I don't think its used much but let' s go

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@michaelfeil
Copy link
Copy Markdown
Contributor Author

Seems like a unrelated failure

@ArthurZucker ArthurZucker merged commit 229bdf3 into huggingface:main Mar 26, 2026
29 of 33 checks passed
@ArthurZucker
Copy link
Copy Markdown
Collaborator

Yep!

@Qubitium
Copy link
Copy Markdown
Contributor

Hi @ArthurZucker @michaelfeil I just ran into this PR and am curious at the structure: why is BaseTokenizer another wrapper which holds the real tokenzer in _tokenizer? Since the naming and the code is confusing me a little. It's been a long time since I checked the internals of hf tokenizers so I am really clueless and want to start.

@ArthurZucker
Copy link
Copy Markdown
Collaborator

its not an internal its more like an example of how you can use. I don't think many people use it tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants