Waive the audit on the NEWS entry that records is_border_4()'s removal - #15
Merged
Conversation
A new meta-repo audit trigger resolves every sibling-ecosystem `pkg::fn` reference against that package's committed sources, and reports one naming a function that exists nowhere. This NEWS entry names `thinr::is_border_4()` -- correctly, because the entry exists to record that it was removed from `src/thinr_common.h`. This is the canonical waiver case the meta CLAUDE.md describes: naming the problem IS the fix, so the line carries a token rather than being reworded. Rewording it to dodge the pattern would delete the only record of what was removed, which is the entry's whole purpose. The token goes on the line ABOVE, the position the check supports for exactly this reason: the reference sits mid-sentence in a wrapped bullet, and an inline HTML comment would break the bullet. A path escape was considered and rejected. The meta CLAUDE.md says the one existing path escape, `REVIEW-*.md`, "is not a precedent" -- and a NEWS.md exemption would silence every future false claim in this file, not this one true one. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new meta-repo audit trigger resolves every sibling-ecosystem
pkg::fnreference against that package's committed sources, and reports one naming a
function that exists nowhere. This NEWS entry names
thinr::is_border_4()--correctly, because the entry exists to record that it was removed from
src/thinr_common.h.This is the canonical waiver case the meta CLAUDE.md describes: naming the
problem IS the fix, so the line carries a token rather than being reworded.
Rewording it to dodge the pattern would delete the only record of what was
removed, which is the entry's whole purpose.
The token goes on the line ABOVE, the position the check supports for exactly
this reason: the reference sits mid-sentence in a wrapped bullet, and an
inline HTML comment would break the bullet.
A path escape was considered and rejected. The meta CLAUDE.md says the one
existing path escape,
REVIEW-*.md, "is not a precedent" -- and a NEWS.mdexemption would silence every future false claim in this file, not this one
true one.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com