Repository navigation
Keep security and routine Node proposals independent and refresh after dependency changes - #34
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
|
PR-cycle state — maintained automatically. Do not edit by hand. Mechanical PR-cycle state (JSON){
"approval": {
"candidate_revision_fingerprint": "sha256:03bd855e3dba25d34a0cf59d0721ff1be659450717a016cb48678d6574359ab3",
"evidence": {
"attestations": [],
"candidate_revision_fingerprint": "sha256:03bd855e3dba25d34a0cf59d0721ff1be659450717a016cb48678d6574359ab3",
"check_conclusions": [
{
"conclusion": "SUCCESS",
"name": "test",
"run_id": 118741076920
},
{
"conclusion": "SUCCESS",
"name": "toolchain (22, npm, 11.9.0)",
"run_id": 118741077428
},
{
"conclusion": "SUCCESS",
"name": "toolchain (22, pnpm, 11.20.0)",
"run_id": 118741077810
},
{
"conclusion": "SUCCESS",
"name": "toolchain (22, pnpm, 11.21.0)",
"run_id": 118741077502
},
{
"conclusion": "SUCCESS",
"name": "toolchain (24, npm, 11.9.0)",
"run_id": 118741077632
},
{
"conclusion": "SUCCESS",
"name": "toolchain (24, pnpm, 11.20.0)",
"run_id": 118741077938
},
{
"conclusion": "SUCCESS",
"name": "toolchain (24, pnpm, 11.21.0)",
"run_id": 118741077572
}
],
"delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
"finding_dispositions_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
"operation_identity": "sha256:25e3a8b79bcd9afb81386fe1047cae39d3ff22ed19fe3c05330cc356b125c265",
"review_request": {
"body_digest": "sha256:6835b3203b65f31912c805a4ef40065c27c6c3bb00042bc8cf8bbe86f1a7294b",
"id": 6295608263
},
"review_result": {
"body_digest": "sha256:7b860d04195fa536ed681877e8f2c451e67f403317a8915e177cc085b4706983",
"id": 6295723446
}
},
"evidence_fingerprint": "sha256:dcfecf8d9e141e9f77aab63d4b2f7751fff65248a31ef33710c74a8e757c8b26",
"head_sha": "6f52bd366c84dcd2e0c5c60c1173ea25f4e218c8",
"operation_identity": "sha256:25e3a8b79bcd9afb81386fe1047cae39d3ff22ed19fe3c05330cc356b125c265",
"review_request_id": 6295608263,
"review_result_id": 6295723446,
"status": "approved-evidence-recorded"
},
"candidate_revision_fingerprint": "sha256:03bd855e3dba25d34a0cf59d0721ff1be659450717a016cb48678d6574359ab3",
"check_conclusions": [
{
"conclusion": "SUCCESS",
"name": "test",
"run_id": 118741076920
},
{
"conclusion": "SUCCESS",
"name": "toolchain (22, npm, 11.9.0)",
"run_id": 118741077428
},
{
"conclusion": "SUCCESS",
"name": "toolchain (22, pnpm, 11.20.0)",
"run_id": 118741077810
},
{
"conclusion": "SUCCESS",
"name": "toolchain (22, pnpm, 11.21.0)",
"run_id": 118741077502
},
{
"conclusion": "SUCCESS",
"name": "toolchain (24, npm, 11.9.0)",
"run_id": 118741077632
},
{
"conclusion": "SUCCESS",
"name": "toolchain (24, pnpm, 11.20.0)",
"run_id": 118741077938
},
{
"conclusion": "SUCCESS",
"name": "toolchain (24, pnpm, 11.21.0)",
"run_id": 118741077572
}
],
"check_observations": [
{
"checks": [
{
"conclusion": "SUCCESS",
"name": "test",
"run_id": 118741076920,
"run_status": "completed",
"status": "success",
"url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39455473817/job/118741076920"
},
{
"conclusion": "SUCCESS",
"name": "toolchain (22, npm, 11.9.0)",
"run_id": 118741077428,
"run_status": "completed",
"status": "success",
"url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39455473817/job/118741077428"
},
{
"conclusion": "SUCCESS",
"name": "toolchain (22, pnpm, 11.20.0)",
"run_id": 118741077810,
"run_status": "completed",
"status": "success",
"url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39455473817/job/118741077810"
},
{
"conclusion": "SUCCESS",
"name": "toolchain (22, pnpm, 11.21.0)",
"run_id": 118741077502,
"run_status": "completed",
"status": "success",
"url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39455473817/job/118741077502"
},
{
"conclusion": "SUCCESS",
"name": "toolchain (24, npm, 11.9.0)",
"run_id": 118741077632,
"run_status": "completed",
"status": "success",
"url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39455473817/job/118741077632"
},
{
"conclusion": "SUCCESS",
"name": "toolchain (24, pnpm, 11.20.0)",
"run_id": 118741077938,
"run_status": "completed",
"status": "success",
"url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39455473817/job/118741077938"
},
{
"conclusion": "SUCCESS",
"name": "toolchain (24, pnpm, 11.21.0)",
"run_id": 118741077572,
"run_status": "completed",
"status": "success",
"url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39455473817/job/118741077572"
}
],
"head_sha": "6f52bd366c84dcd2e0c5c60c1173ea25f4e218c8",
"id": "sha256:fab5482341df3196a41f01063b13b3793d89a789ab7a9b73544b6b43872d1274",
"required_checks": [
"test",
"toolchain (22, npm, 11.9.0)",
"toolchain (22, pnpm, 11.20.0)",
"toolchain (22, pnpm, 11.21.0)",
"toolchain (24, npm, 11.9.0)",
"toolchain (24, pnpm, 11.20.0)",
"toolchain (24, pnpm, 11.21.0)"
],
"status": "success"
}
],
"delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
"delivery_deferrals": [],
"findings": [],
"pr": {
"base_ref": "main",
"base_sha": "6829ff794972a69fdba80c2b6448503681c8d078",
"body_digest": "sha256:a6e31f5109fe9ff8d022b9e5663e3fed3911d0625c0da4b2c3003e7f2de75f13",
"diff_digest": "sha256:4a45b31b58a9e09c1fa096b4155f9ebd6ac222bc1a0187188029a1cc7672a05c",
"head_ref": "node-coordinated-proposals",
"head_sha": "6f52bd366c84dcd2e0c5c60c1173ea25f4e218c8",
"pr": 34,
"repository": "hydra-ecosystem/github-actions",
"scope_authority": [],
"title_digest": "sha256:fd87c9067546be070d62473d9cc97aa0619b7b6e84b1a41af304475e8737d475"
},
"record_version": 4,
"review_observations": [],
"review_requests": [
{
"base_established_at": "2026-10-20T16:13:02Z",
"base_ref": "main",
"base_sha": "6829ff794972a69fdba80c2b6448503681c8d078",
"body_digest": "sha256:6835b3203b65f31912c805a4ef40065c27c6c3bb00042bc8cf8bbe86f1a7294b",
"created_at": "2026-10-20T16:18:29Z",
"head_sha": "6f52bd366c84dcd2e0c5c60c1173ea25f4e218c8",
"id": 6295608263,
"kind": "regular-review"
}
],
"review_results": [
{
"base_ref": "main",
"base_sha": "6829ff794972a69fdba80c2b6448503681c8d078",
"body_digest": "sha256:7b860d04195fa536ed681877e8f2c451e67f403317a8915e177cc085b4706983",
"commit_id": "6f52bd366c84dcd2e0c5c60c1173ea25f4e218c8",
"id": 6295723446,
"inline_message_ids": [],
"request_comment_id": 6295608263,
"result_kind": "clean",
"status": "result",
"submitted_at": "2026-10-20T16:24:11Z",
"unresolved_thread_ids": []
}
],
"revision_fingerprint": "sha256:03bd855e3dba25d34a0cf59d0721ff1be659450717a016cb48678d6574359ab3",
"rounds": [
{
"applied_fix_paths": [],
"disposition_changes": [],
"effective_diff_digest": "sha256:4a45b31b58a9e09c1fa096b4155f9ebd6ac222bc1a0187188029a1cc7672a05c",
"finding_ids": [],
"invariants": [
"Security and upgrades proposals keep independent branches",
"Push refreshes never create replacement PRs",
"Relevant pushes validate main even without open proposals",
"Stale publication is refused"
],
"outcome": "clean",
"proposed_fix_paths": [],
"resulting_head": "6f52bd366c84dcd2e0c5c60c1173ea25f4e218c8",
"review_observation_id": null,
"review_request_id": 6295608263,
"review_result_id": 6295723446,
"reviewed_head": "6f52bd366c84dcd2e0c5c60c1173ea25f4e218c8",
"root_cause": "No current-slice defects identified by the attributable review or validation.",
"round": 1,
"unresolved_current_slice_findings": 0,
"unresolved_design_blockers": 0
}
],
"schema": "awd:swe:pr-cycle-state",
"version": 2
} |
Contributor
Author
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security-only audits currently share a branch with routine upgrades, so a later security run can replace an existing upgrades proposal. Add an opt-in coordinated caller that keeps one security PR and one upgrades PR, each generated from the current default branch.
Matching default-branch pushes validate committed dependencies even when no proposal is open, then refresh existing channel PRs without creating replacements. Refreshes reject stale publication inputs, preserve drafts, and comment before closing obsolete proposals without replacing their descriptions. The caller queues pending runs and watches only lockfiles and the maintenance configuration; a precheck ignores lockfiles outside the selected project.
Existing two-job callers remain supported. The fleet checker recognizes the new caller, and the adoption guide covers legacy PR disposition, schedules, permissions, and the merge window without strict branch protection. No release tag or consumer installation changes are included.
Validation: