Repository navigation
Preserve configuration-issue history when preflight recovers - #36
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
|
PR-cycle state — maintained automatically. Do not edit by hand. Mechanical PR-cycle state (JSON){
"approval": {
"candidate_revision_fingerprint": "sha256:5015e4d57b1689864947439ce8ba63c1f50658860da593a754a67f77ae930322",
"evidence": {
"attestations": [],
"candidate_revision_fingerprint": "sha256:5015e4d57b1689864947439ce8ba63c1f50658860da593a754a67f77ae930322",
"check_conclusions": [
{
"conclusion": "SUCCESS",
"name": "test",
"run_id": 118821795544
},
{
"conclusion": "SUCCESS",
"name": "toolchain (22, npm, 11.9.0)",
"run_id": 118821795788
},
{
"conclusion": "SUCCESS",
"name": "toolchain (22, pnpm, 11.20.0)",
"run_id": 118821796028
},
{
"conclusion": "SUCCESS",
"name": "toolchain (22, pnpm, 11.21.0)",
"run_id": 118821796046
},
{
"conclusion": "SUCCESS",
"name": "toolchain (24, npm, 11.9.0)",
"run_id": 118821796238
},
{
"conclusion": "SUCCESS",
"name": "toolchain (24, pnpm, 11.20.0)",
"run_id": 118821796120
},
{
"conclusion": "SUCCESS",
"name": "toolchain (24, pnpm, 11.21.0)",
"run_id": 118821796137
}
],
"delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
"finding_dispositions_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
"operation_identity": "sha256:3e7f54673c3757a862ea637b9e1e42e57af5d31bfab2c30032dd3b2cc5012768",
"review_request": {
"body_digest": "sha256:b4f19562df79b6b3260bc0fdd2e1817b6d8e3f8e086177177875af9ea52e5179",
"id": 6298872770
},
"review_result": {
"body_digest": "sha256:cf2108e9d9c6dea63df7ad2a1d3571ddf96129fa2a83258f44e7c9e32ab93d66",
"id": 6298903374
}
},
"evidence_fingerprint": "sha256:d3ff82f6d04cf09c2d9991aeefe41660fc56737672ca615f233d8c553ec50789",
"head_sha": "6b76724579ebf1c6c1dbb9dbff9cf9470d48fe4f",
"operation_identity": "sha256:3e7f54673c3757a862ea637b9e1e42e57af5d31bfab2c30032dd3b2cc5012768",
"review_request_id": 6298872770,
"review_result_id": 6298903374,
"status": "approved-evidence-recorded"
},
"candidate_revision_fingerprint": "sha256:5015e4d57b1689864947439ce8ba63c1f50658860da593a754a67f77ae930322",
"check_conclusions": [
{
"conclusion": "SUCCESS",
"name": "test",
"run_id": 118821795544
},
{
"conclusion": "SUCCESS",
"name": "toolchain (22, npm, 11.9.0)",
"run_id": 118821795788
},
{
"conclusion": "SUCCESS",
"name": "toolchain (22, pnpm, 11.20.0)",
"run_id": 118821796028
},
{
"conclusion": "SUCCESS",
"name": "toolchain (22, pnpm, 11.21.0)",
"run_id": 118821796046
},
{
"conclusion": "SUCCESS",
"name": "toolchain (24, npm, 11.9.0)",
"run_id": 118821796238
},
{
"conclusion": "SUCCESS",
"name": "toolchain (24, pnpm, 11.20.0)",
"run_id": 118821796120
},
{
"conclusion": "SUCCESS",
"name": "toolchain (24, pnpm, 11.21.0)",
"run_id": 118821796137
}
],
"check_observations": [
{
"checks": [
{
"conclusion": "SUCCESS",
"name": "test",
"run_id": 118821795544,
"run_status": "completed",
"status": "success",
"url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39478841328/job/118821795544"
},
{
"conclusion": "SUCCESS",
"name": "toolchain (22, npm, 11.9.0)",
"run_id": 118821795788,
"run_status": "completed",
"status": "success",
"url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39478841328/job/118821795788"
},
{
"conclusion": "SUCCESS",
"name": "toolchain (22, pnpm, 11.20.0)",
"run_id": 118821796028,
"run_status": "completed",
"status": "success",
"url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39478841328/job/118821796028"
},
{
"conclusion": "SUCCESS",
"name": "toolchain (22, pnpm, 11.21.0)",
"run_id": 118821796046,
"run_status": "completed",
"status": "success",
"url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39478841328/job/118821796046"
},
{
"conclusion": "SUCCESS",
"name": "toolchain (24, npm, 11.9.0)",
"run_id": 118821796238,
"run_status": "completed",
"status": "success",
"url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39478841328/job/118821796238"
},
{
"conclusion": "SUCCESS",
"name": "toolchain (24, pnpm, 11.20.0)",
"run_id": 118821796120,
"run_status": "completed",
"status": "success",
"url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39478841328/job/118821796120"
},
{
"conclusion": "SUCCESS",
"name": "toolchain (24, pnpm, 11.21.0)",
"run_id": 118821796137,
"run_status": "completed",
"status": "success",
"url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39478841328/job/118821796137"
}
],
"head_sha": "6b76724579ebf1c6c1dbb9dbff9cf9470d48fe4f",
"id": "sha256:62133d8c032ba74b766cbf087dfbeadcf744d49ac568bc2b7b685f6fb940fbdb",
"required_checks": [
"test",
"toolchain (22, npm, 11.9.0)",
"toolchain (22, pnpm, 11.20.0)",
"toolchain (22, pnpm, 11.21.0)",
"toolchain (24, npm, 11.9.0)",
"toolchain (24, pnpm, 11.20.0)",
"toolchain (24, pnpm, 11.21.0)"
],
"status": "success"
}
],
"delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
"delivery_deferrals": [],
"findings": [],
"pr": {
"base_ref": "main",
"base_sha": "a72573a2029c4a80136b6a23e57790c08d9ebc5c",
"body_digest": "sha256:1d2305f111efdd7a68e85412813307a26b5701caec4aacbb741de37cc82262f9",
"diff_digest": "sha256:d9cfc7042c38ea6b17a096b203997199bf056b224555c823b602adf0bdaf1282",
"head_ref": "fix/configuration-issue-recovery-history",
"head_sha": "6b76724579ebf1c6c1dbb9dbff9cf9470d48fe4f",
"pr": 36,
"repository": "hydra-ecosystem/github-actions",
"scope_authority": [],
"title_digest": "sha256:6e0e6dfa0f20c856d40821217f4fd26d7f07ff3c29cd6edea4cddc59ef244e7c"
},
"record_version": 4,
"review_observations": [],
"review_requests": [
{
"base_established_at": "2026-10-20T18:54:27Z",
"base_ref": "main",
"base_sha": "a72573a2029c4a80136b6a23e57790c08d9ebc5c",
"body_digest": "sha256:b4f19562df79b6b3260bc0fdd2e1817b6d8e3f8e086177177875af9ea52e5179",
"created_at": "2026-10-20T19:03:07Z",
"head_sha": "6b76724579ebf1c6c1dbb9dbff9cf9470d48fe4f",
"id": 6298872770,
"kind": "regular-review"
}
],
"review_results": [
{
"base_ref": "main",
"base_sha": "a72573a2029c4a80136b6a23e57790c08d9ebc5c",
"body_digest": "sha256:cf2108e9d9c6dea63df7ad2a1d3571ddf96129fa2a83258f44e7c9e32ab93d66",
"commit_id": "6b76724579ebf1c6c1dbb9dbff9cf9470d48fe4f",
"id": 6298903374,
"inline_message_ids": [],
"request_comment_id": 6298872770,
"result_kind": "clean",
"status": "result",
"submitted_at": "2026-10-20T19:04:31Z",
"unresolved_thread_ids": []
}
],
"revision_fingerprint": "sha256:5015e4d57b1689864947439ce8ba63c1f50658860da593a754a67f77ae930322",
"rounds": [
{
"applied_fix_paths": [],
"disposition_changes": [],
"effective_diff_digest": "sha256:d9cfc7042c38ea6b17a096b203997199bf056b224555c823b602adf0bdaf1282",
"finding_ids": [],
"invariants": [
"Recovery preserves last failure body",
"Recovery comment precedes closure",
"Recovery retry does not duplicate comment",
"Failed comment leaves issue open"
],
"outcome": "clean",
"proposed_fix_paths": [],
"resulting_head": "6b76724579ebf1c6c1dbb9dbff9cf9470d48fe4f",
"review_observation_id": null,
"review_request_id": 6298872770,
"review_result_id": 6298903374,
"reviewed_head": "6b76724579ebf1c6c1dbb9dbff9cf9470d48fe4f",
"root_cause": null,
"round": 1,
"unresolved_current_slice_findings": 0,
"unresolved_design_blockers": 0
}
],
"schema": "awd:swe:pr-cycle-state",
"version": 2
} |
Contributor
Author
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A successful configuration preflight currently replaces the original failure description before closing its issue. The recovery in yadan.net #9 exposed the lost diagnostic history.
Use the existing resolution-comment path to post a verification-run link before closing, preserving the failure description. Repeated healthy runs stay quiet; a retry after a failed close reuses the comment, and a failed comment write leaves the issue open. The reporter's rerun instruction also works with either supported caller name.
Validation: the recovery regression failed against the old behavior; 64 focused tests and all 1,234 public tests pass with the fix, along with Ruff lint/format and Pyrefly. Tests cover description preservation, comment-write failure, and close-request retry.