Implement/derive Eq+PartialEq for more types#137
Open
filips123 wants to merge 1 commit intohyperium:masterfrom
Open
Implement/derive Eq+PartialEq for more types#137filips123 wants to merge 1 commit intohyperium:masterfrom
filips123 wants to merge 1 commit intohyperium:masterfrom
Conversation
kailan
approved these changes
Sep 13, 2021
|
@kailan can you please merge this, ugh I'd hate having to fork this crate. |
|
@bsodmike I'm not a maintainer unfortunately |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is very similar to #128 and can replace it, because it also implements/derives Eq+PartialEq traits for more (I think all) public types. Reasons for this are the same as in #128, but I applied them to more types.
The main types where I think that is useful (apart from
Mime) areMediaTypeandMediaRange(to allowmatching them and using them in structs that also want to implementEq) andParseError(to allowmatchingspecific errors), but I hope adding Eq+PartialEq to more types won't hurt.