Conversation
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
When the blockchain connector delivers the same on-chain log twice within one batch, FireFly emits two blockchain_event_received events with the same reference, pointing at the same blockchain_events row.
InsertNewBlockchainEvents' insert-or-get fallback queries the events table to decide whether a duplicate blockchain_events row still needs a notification, but that query only sees events committed in previous batches — the FF events for earlier entries of the current batch are inserted later, in maybePersistBlockchainEvents. So the second entry falls through the "partial success" branch and both end up in inserted.
Symptom observed:
Originally thought about adding a new set with IDs to be O(1) but batches are small so we can iterate over the array
Types of changes
Please make sure to follow these points