fix: garbled FF10315 and FF10365 error messages - #1791
Open
NotAFlightRisk wants to merge 1 commit into
Open
NotAFlightRisk wants to merge 1 commit into
NotAFlightRisk wants to merge 1 commit into
Conversation
Signed-off-by: Iain <iain1970@protonmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Mistype the method name when you invoke a contract API and the 400 comes back as
FF10315: Unable to resolve contract method: sett%!(EXTRA <nil>). FF10365 does the same if you register a custom identity under a node - its text is one%sshort, so it ends... of type%!(EXTRA fftypes.FFEnum=custom).No open issue, though FF10315 is the one from #1472. #1473 added the method name but left
errin as an extra insert, wich the message has no slot for.Types of changes
Please make sure to follow these points
Screenshots (If Applicable)
N/A
Other Information
For FF10315 I went with
WrapErrorrather than a second%sin the text, sinceerris nil when the method just isnt there and you'd get<nil>on the end instead. A DB error still shows after the method name, eg...: sett: pop.