Skip to content

Incorrect type for message in FireFlyTokenTransferRequest #63

Description

@shorsher

It seems the type for message within FireFlyTokenTransferRequest is incorrect. Instead of accepting a message object, it is expecting a string.

    requestBody: {
      content: {
        "application/json": {
          ....
          ....
          /**
           * Format: uuid
           * @description The UUID of a message that has been correlated with this transfer using the data field of the transfer in a compatible token connector
           */
          message?: string;
          ....
          ....
        };
      };
    };

https://github.com/hyperledger/firefly/blob/main/pkg/core/tokentransfer.go#L29-L55
This may be a limitation of the swagger generator, because Message is type fftypes.UUID on TokenTransfer, but the actual input for that api is TokenTransferInput, which wraps TokenTransfer and also has a Message field of type MessageInOut.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions