Support multiple Rust toolchain files - #20
Open
simongdavies wants to merge 1 commit into
Open
simongdavies wants to merge 1 commit into
simongdavies wants to merge 1 commit into
Conversation
Accept one or two toolchain directories and install the versions, components, and targets declared by their native rustup files. Document the breaking v2 interface and explicit default selection. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
A critical Windows path-handling issue in action.yml must be fixed before approval.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Updates the GitHub Action to support one or two Rust toolchain directories, install their declared components and targets, and select an explicit default toolchain.
Changes:
- Replaces the single toolchain input with directory-based configuration.
- Adds validation and multi-toolchain installation.
- Documents the v2 interface and default-selection behavior.
| File | Description |
|---|---|
README.md |
Documents the v2 inputs and behavior. |
action.yml |
Validates directories, installs toolchains, and selects the default. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| run: | | ||
| fail() { echo "$*" >&2; exit 1; } | ||
| trim() { printf '%s\n' "$1" | sed 's/^[[:space:]]*//; s/[[:space:]]*$//'; } | ||
| cd "$GITHUB_WORKSPACE" |
ludfjig
requested changes
Sep 22, 2026
Contributor
There was a problem hiding this comment.
I would simplify the v2 interface to:
inputs:
additional-toolchain-directory:
description: "Optional directory containing another Rust toolchain file."
required: false
Then:
- uses: actions-rust-lang/setup-rust-toolchain@<sha>
with:
cache: 'false'
matcher: 'false'
build-warnings: ''
- if: ${{ inputs.additional-toolchain-directory != '' }}
uses: actions-rust-lang/setup-rust-toolchain@<sha>
with:
rust-src-dir: ${{ inputs.additional-toolchain-directory }}
cache: 'false'
matcher: 'false'
build-warnings: ''
This removes the PR’s lines 21–54 and 83–99.
What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept one or two toolchain directories and install the versions, components, and targets declared by their native rustup files.
Document the breaking v2 interface and explicit default selection.