Address final macOS review nits - #333
Open
simongdavies wants to merge 1 commit into
Open
simongdavies wants to merge 1 commit into
simongdavies wants to merge 1 commit into
Conversation
simongdavies
added this pull request to stack #311
September 29, 2026 08:16
simongdavies
force-pushed
the
simongdavies-address-final-macos-nits
branch
from
September 29, 2026 09:07
9dc2fa3 to
b7891bf
Compare
simongdavies
force-pushed
the
simongdavies-address-final-macos-nits
branch
from
September 30, 2026 18:11
b7891bf to
018551d
Compare
ludfjig
previously approved these changes
Sep 30, 2026
simongdavies
force-pushed
the
simongdavies-address-final-macos-nits
branch
from
October 1, 2026 22:45
018551d to
b7351d5
Compare
Document LLVM archiver discovery, explain the Mach safety invariants, and remove the unused Windows hypervisor alias. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
simongdavies
force-pushed
the
simongdavies-address-final-macos-nits
branch
from
October 2, 2026 06:54
b7351d5 to
8baa6e4
Compare
ludfjig
approved these changes
Oct 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the final review nits on #308 by clarifying compatible LLVM discovery for guest builds, documenting the safety invariants around macOS thread CPU accounting, and removing an unused cfg alias.