fix(typecheck): make len/show truly polymorphic schemes (Refs #122)#125
Merged
Conversation
v2.5/v2.6 (merged in #123) bound `len` and `show` via `bind_var` as `'a -> Int` / `'a -> String` using a SINGLE SHARED unification tyvar, not a generalized scheme. The first use pinned it (e.g. `len(name)` => tv:=String), so a later `len(ids)` on `[String]` failed with `Unify TypeMismatch (String, Array[String])`. This blocked any program mixing `len` over strings and arrays — notably the ubicity#30 storage port (diagnosed to root cause via an `sb7` minimal repro). Bind both as generalized schemes via `bind_scheme` (`poly1` helper: fresh tyvar quantified in `sc_tyvars`, instantiated per call site), so `len`/`show` are properly polymorphic. Verified green prior to an environment loss (WSL /tmp wipe): the sb7 repro and the full ubicity storage.affine compiled; the 5 Deno-ESM harnesses and `dune runtest` (214 tests, unchanged — same 2 pre-existing E2E Node-CJS vscode failures) all passed. CI re-verifies the build here. Refs #122 (follow-up to #123; unblocks ubicity#30). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
hyperpolymath
added a commit
that referenced
this pull request
May 16, 2026
Synthesised class methods are `async` and an associated cross-method
call lowers to `(await this.m(...))`. But the expression-position IIFE
wrappers (block / try / match / let / return) were always plain
`(() => { ... })()` — so a contained `await` produced
`SyntaxError: Unexpected reserved word` (hit by ubicity's
`loadAllExperiences`: a try whose body `await this.ensureDirectories()`).
Add `ctx.in_async` (set while emitting a synthesised `async` method
body) and an `iife` helper: in async context the wrapper is
`(await (async () => { ... })())`, otherwise the plain form. Applied to
gen_block_expr / gen_try / gen_match / ExprLet / ExprReturn /
ExprUnsafe. Free functions, constructors and module top-level stay
non-async (they never emit an awaited associated call).
Verified: affinescript `dune build` clean, `dune runtest` 214 tests /
same 2 pre-existing E2E Node-CJS vscode failures (zero regressions),
5 Deno-ESM harnesses green; the regenerated ubicity src/storage.js now
parses and `deno task test` is **44 passed / 0 failed** (the full suite,
incl. the .test.js variants that import the migrated storage.js via
mapper/privacy/export).
Refs #122 (follow-up to #123/#125; completes the ubicity#30 consumer).
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(typecheck): make len/show truly polymorphic schemes (Refs #122)
v2.5/v2.6 (merged in #123) bound
lenandshowviabind_varas'a -> Int/'a -> Stringusing a SINGLE SHARED unification tyvar,not a generalized scheme. The first use pinned it (e.g.
len(name)=> tv:=String), so a later
len(ids)on[String]failed withUnify TypeMismatch (String, Array[String]). This blocked any programmixing
lenover strings and arrays — notably the ubicity#30 storageport (diagnosed to root cause via an
sb7minimal repro).Bind both as generalized schemes via
bind_scheme(poly1helper:fresh tyvar quantified in
sc_tyvars, instantiated per call site), solen/showare properly polymorphic.Verified green prior to an environment loss (WSL /tmp wipe): the sb7
repro and the full ubicity storage.affine compiled; the 5 Deno-ESM
harnesses and
dune runtest(214 tests, unchanged — same 2 pre-existingE2E Node-CJS vscode failures) all passed. CI re-verifies the build here.
Refs #122 (follow-up to #123; unblocks ubicity#30).
Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com