ci(hypatia-scan): add --exit-zero + GITHUB_TOKEN to canonical template#54
Merged
Merged
Conversation
The standards repo's hypatia-scan.yml is the template that consumer repos cargo-cult across the estate. The scan command ran without `--exit-zero` or `|| true`, so under `set -e` it short-circuited the rest of the step whenever findings existed — silently breaking the downstream "Check for critical or high-severity issues" gate. Adds --exit-zero (canonical) and the GITHUB_TOKEN env (silences the "Dependabot alerts unavailable" warning), matching what hyperpolymath/hypatia#228 already landed in hypatia's own copy. Fixing the root template here so any new repos templated from standards inherit the correct pattern. Existing affected consumers need their own follow-up sweep (see panll#28, lcb-website#9, aerie#19 for the pattern).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root-cause fix for the estate-wide hypatia-scan.yml drift. The standards repo's template is what consumers cargo-cult; without
--exit-zero(or|| true), the scan step short-circuits underset -ewhenever findings exist.Adds
--exit-zero(canonical, matches hyperpolymath/hypatia#228) and theGITHUB_TOKENenv (silences the Dependabot-alerts warning).🤖 Generated with Claude Code