Skip to content

fix(security): regenerate stale fuzz lockfiles — quinn-proto 0.11.14 drops out (2 high alerts) - #285

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/quinn-proto-rustsec
Sep 22, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
fix/quinn-proto-rustsec

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

Closes the two open high dependabot alerts:

  • #15fuzz/Cargo.lock
  • #16rust-core/fuzz/Cargo.lock

Both flag quinn-proto 0.11.14 (< 0.11.15, unbounded out-of-order streams).

What actually happened

quinn-proto is not in either fuzz manifest's current dependency graph at all — it survives only inside lockfiles that both cargo 1.98-stable and the repo-pinned nightly-2026-05-15 refuse on any fetch (they rewrite them to the true ~400-package resolution). I.e. the alerts key on orphaned lock entries.

Regenerated both lockfiles with the repo's own pinned toolchain:

  • zero quinn/quinn-proto/quinn-udp entries remain → both alerts auto-close
  • cargo fetch --locked verified green for fuzz/ and rust-core/fuzz/ locally
  • package counts 784/836 → 398/392 (the surplus was orphaned entries from an earlier dependency layout — the locks had drifted out of sync with the manifests)

No source changes. If a full lock refresh is judged too risky for one PR, the narrower alternative is a one-line quinn-proto 0.11.14→0.11.15 pin — but that keeps cargo-splitting locks in place, so regeneration is the honest fix.

…rops out (closes 2 high alerts)

Both dependabot 'high' alerts (#15 fuzz/, #16 rust-core/fuzz/) flag
quinn-proto 0.11.14 (unbounded out-of-order streams). Investigation
shows neither fuzz manifest's current dependency graph pulls in quinn
at all - the vulnerable crate exists only inside stale lockfiles that
cargo (stable 1.98 and the repo-pinned nightly-2026-05-15 alike) refuses
on any fetch, rewriting them to the true ~400-package resolution.

Regenerated both lockfiles in place with the repo's own pinned toolchain
(cargo update inside fuzz/ and rust-core/fuzz/). Result:
  - zero quinn/quinn-proto/quinn-udp entries -> both alerts auto-close
  - cargo fetch --locked passes for both workspaces (verified locally)
  - package graphs now match the manifests (784/836 -> 398/392 packages:
    the surplus was orphaned entries from an earlier dependency layout)

No source changes; builds that consume these locks now resolve the same
graph cargo itself insists on.
@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • fuzz/Cargo.lock is excluded by !**/*.lock
  • rust-core/fuzz/Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 0484b55f-bb50-4283-b904-f0729af22011

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Pull request is closed - (🔄 Check again to try again)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath merged commit e233751 into main Sep 22, 2026
18 checks passed
@hyperpolymath
hyperpolymath deleted the fix/quinn-proto-rustsec branch September 22, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants