Skip to content

fix: fix security issue in StatusRoutes.js #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fix security issue in StatusRoutes.js #262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 27 additions & 4 deletions src/routes/StatusRoutes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,29 @@ const VersionChecker = require("../utils/VersionChecker");
const LoggingService = require("../utils/LoggingService");
const UsageStatsService = require("../core/UsageStatsService");

// Lightweight in-memory rate limiter to protect authenticated endpoints from abuse/resource exhaustion
function createRateLimiter({ windowMs, max }) {
const hits = new Map();
return (req, res, next) => {
const key = req.session?.id || req.ip;
const now = Date.now();
const record = hits.get(key);
if (!record || now - record.start > windowMs) {
hits.set(key, { count: 1, start: now });
return next();
}
record.count += 1;
if (record.count > max) {
return res.status(429).json({ message: "tooManyRequests" });
}
return next();
};
}

const statusRateLimiter = createRateLimiter({ max: 60, windowMs: 60 * 1000 });
const usageStatsRateLimiter = createRateLimiter({ max: 30, windowMs: 60 * 1000 });
const usageStatsImportRateLimiter = createRateLimiter({ max: 5, windowMs: 60 * 1000 });

/**
* Status Routes Manager
* Manages system status, account management, and settings routes
Expand Down Expand Up @@ -125,7 +148,7 @@ class StatusRoutes {
}
});

app.get("/api/status", isAuthenticated, async (req, res) => {
app.get("/api/status", isAuthenticated, statusRateLimiter, async (req, res) => {
// Force a reload of auth sources on each status check for real-time accuracy
const hasChanges = this.serverSystem.authSource.reloadAuthSources();

Expand Down Expand Up @@ -177,12 +200,12 @@ class StatusRoutes {
res.json(this._getStatusData());
});

app.get("/api/usage-stats", isAuthenticated, (req, res) => {
app.get("/api/usage-stats", isAuthenticated, usageStatsRateLimiter, (req, res) => {
const snapshot = this.serverSystem.usageStatsService?.getSnapshot();
res.json(snapshot || UsageStatsService.createEmptySnapshot());
});

app.get("/api/usage-stats/download", isAuthenticated, async (req, res) => {
app.get("/api/usage-stats/download", isAuthenticated, usageStatsRateLimiter, async (req, res) => {
try {
const usageStatsService = this.serverSystem.usageStatsService;
if (!usageStatsService?.enabled) {
Expand Down Expand Up @@ -214,7 +237,7 @@ class StatusRoutes {
}
});

app.post("/api/usage-stats/import", isAuthenticated, async (req, res) => {
app.post("/api/usage-stats/import", isAuthenticated, usageStatsImportRateLimiter, async (req, res) => {
try {
const usageStatsService = this.serverSystem.usageStatsService;
if (!usageStatsService?.enabled) {
Expand Down