Skip to content

Conversation

@TartanLeGrand
Copy link
Contributor

@TartanLeGrand TartanLeGrand commented Mar 6, 2025

This pull request updates the GitHub Actions workflow for building Docker images. The changes introduce new options for linting Dockerfiles with Hadolint, improve the security scan process, and enhance the handling of secrets for Docker Hub login.

Key changes include:

Workflow Enhancements:

  • Added a new input option to enable Hadolint linting for Dockerfiles (.github/workflows/docker-build.yml).
  • Added steps to login to Docker Hub and run Hadolint if the respective inputs are enabled (.github/workflows/docker-build.yml).

Security Improvements:

  • Modified the security scan process to build the Docker image as a tarball before scanning with Trivy (.github/workflows/docker-build.yml).
  • Updated the workflow to post security scan results and Hadolint results as comments on the pull request (.github/workflows/docker-build.yml).

Secret Handling:

  • Changed the required status of Docker Hub secrets to optional (.github/workflows/docker-build.yml).

@TartanLeGrand TartanLeGrand changed the title fix(docker-build): fix types feat(docker-build): add hadolint and fix trivy Mar 6, 2025
@TartanLeGrand TartanLeGrand merged commit e11b377 into main Mar 21, 2025
1 check passed
@TartanLeGrand TartanLeGrand deleted the fix/docker/types branch March 21, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants