refactor(error): finish ApiError phase3#398
Merged
Merged
Conversation
TCP404
force-pushed
the
boii/error-model-phase3
branch
from
9481f6f to
fc64e69
Compare
TCP404
force-pushed
the
boii/error-model-phase3
branch
from
fc64e69 to
02f42ca
Compare
The managed-runtime background-prepare closure annotated its result as aionui_common::ApiError, which trips the new disallowed_types lint (ApiError is an HTTP boundary type, banned outside routes/middleware). The closure only calls RuntimePrepareService methods that return SystemError, so annotate with that crate-owned error instead. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
piorpua
pushed a commit
that referenced
this pull request
Jun 5, 2026
🤖 I have created a release *beep* *boop* --- ## [0.1.22](v0.1.21...v0.1.22) (2026-06-05) ### Bug Fixes * **acp:** stabilize mode and model source of truth ([#409](#409)) ([300bb1e](300bb1e)) * **conversation:** align workspace path availability handling ([#410](#410)) ([30bc96b](30bc96b)) * **file:** lazy load browse roots ([#406](#406)) ([668c562](668c562)) * prepare managed acp tools locally without cdn ([#408](#408)) ([2a48ae3](2a48ae3)) ### Code Refactoring * **error:** finish ApiError phase3 ([#398](#398)) ([37523ab](37523ab)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ApiErroras the HTTP/API boundary type withAppErrorretained only as a compatibility aliasclippy::disallowed_typesenforcement soApiError/AppErrorare blocked outside explicit boundary filesDbError -> ApiErrorconversion and map DB errors at owning route boundariesVerification
cargo fmt --all -- --checkcargo check --workspacecargo clippy --workspace -- -D warningscargo test -p aionui-common -p aionui-api-types -p aionui-db -p aionui-auth -p aionui-system -p aionui-assistant -p aionui-assets -p aionui-ai-agent -p aionui-conversation -p aionui-team -p aionui-cron -p aionui-channel -p aionui-shell -p aionui-mcpcargo test --workspaceNotes
just pushwill run the repository push gate before updating the branch.