Skip to content

fix(acp): stabilize mode and model source of truth#409

Merged
piorpua merged 2 commits into
mainfrom
round-2-acp-mode-model
Jun 5, 2026
Merged

fix(acp): stabilize mode and model source of truth#409
piorpua merged 2 commits into
mainfrom
round-2-acp-mode-model

Conversation

@piorpua
Copy link
Copy Markdown
Contributor

@piorpua piorpua commented Jun 5, 2026

Summary

  • Treat active ACP mode/model as runtime-confirmed state and persist it through ACP session runtime state.
  • Reconcile create-time model/mode seeds with active sessions without letting conversation.extra become a second source of truth.
  • Reject ACP conversation.extra.current_model_id/current_mode_id writes through the public conversation update path.

Test plan

  • just push -u origin round-2-acp-mode-model
  • Manual dev-log verification for ACP model switching and response flow

@piorpua piorpua enabled auto-merge (squash) June 5, 2026 12:09
@piorpua piorpua merged commit 300bb1e into main Jun 5, 2026
5 checks passed
@piorpua piorpua deleted the round-2-acp-mode-model branch June 5, 2026 12:29
piorpua pushed a commit that referenced this pull request Jun 5, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.1.22](v0.1.21...v0.1.22)
(2026-06-05)


### Bug Fixes

* **acp:** stabilize mode and model source of truth
([#409](#409))
([300bb1e](300bb1e))
* **conversation:** align workspace path availability handling
([#410](#410))
([30bc96b](30bc96b))
* **file:** lazy load browse roots
([#406](#406))
([668c562](668c562))
* prepare managed acp tools locally without cdn
([#408](#408))
([2a48ae3](2a48ae3))


### Code Refactoring

* **error:** finish ApiError phase3
([#398](#398))
([37523ab](37523ab))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant