Fixing problem with rating change not being equal#2
Open
wakeless wants to merge 1 commit intoiain:masterfrom
Open
Fixing problem with rating change not being equal#2wakeless wants to merge 1 commit intoiain:masterfrom
wakeless wants to merge 1 commit intoiain:masterfrom
Conversation
|
This is actually a considerable problem as: x = Elo::Player.new
y = Elo::Player.new
500.times do
x.wins_from(y)
y.wins_from(x)
end
puts x.rating
puts y.ratingresults in around 500 for each whereas with this fix its |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a problem with matches where they don't necessarily have the same change (with 2 players the same rating)
This breaks other specs though and I'm not sure how the expectations were generated.