Repository navigation
Fail release builds when signing secrets are missing - #1
Closed
iamkhalid2 wants to merge 1 commit into
Closed
iamkhalid2 wants to merge 1 commit into
iamkhalid2 wants to merge 1 commit into
Conversation
The release job generated a fresh throwaway key whenever the keystore secrets were absent, producing APKs that can never be updated in place. It now checks all four secrets before building and aborts with an error naming each missing one. The README documents the required secrets. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KNXRMiBKbauxVxR58bSxcb
iamkhalid2
marked this pull request as ready for review
October 15, 2026 22:25
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Khalid · project thread
Before: when the keystore secrets were not set, the release job generated a brand-new key on the runner, signed the APK with it and threw the key away. Each release was signed by a different key, so Android refuses to install it over the previous one. v0.0.1 was published this way (the run log shows all four secrets empty and the "self-signed release key" branch taken).
After: the job checks
ANDROID_KEYSTORE_BASE64,ANDROID_KEYSTORE_PASSWORD,ANDROID_KEY_ALIASandANDROID_KEY_PASSWORDright after checkout and fails with one error annotation per missing secret, before the SDK install and build. The throwaway-key branch is gone, and the verify step now prints the signing certificate digests so each release's key can be checked in the log.How: a new "Require release signing secrets" step; the signing step keeps only the keystore path. A "Release signing" section in the README lists the secrets and how to create and encode the keystore. No key is created or committed.
Tested locally by running the check script with secrets missing (exits 1, names each missing secret) and with all four set (exits 0). The workflow itself has not run on this branch since it only triggers on
v*tags or manual dispatch.🤖 Generated with Claude Code
https://claude.ai/code/session_01KNXRMiBKbauxVxR58bSxcb
Generated by Claude Code