Repository navigation
Make README feature claims match the code - #2
Merged
Merged
Conversation
Remove claims with no implementation (PDF, Book Map, WordNet/Wikipedia lookups, footnote popups, Anki/Readwise/flashcard export, Android Auto, silence skipping, full-cast and quote voices, pronunciation guides, streaks, Geist, Dusk theme, Nav3) and correct the ones that were wrong (EncryptedSharedPreferences, speed range, themes, fonts, exports). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DL7TMvGRPjugDQYxjpStjH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Khalid · project thread
Before: the README advertised features with no code behind them (PDF, Book Map, WordNet/Wikipedia lookups, footnote popups, Anki/Readwise/flashcard export, Android Auto, silence skipping, full-cast and quote voices, pronunciation guides, streaks, Geist font, a Dusk theme, Nav3) and misdescribed others.
After: every feature claim in the README maps to code in the repo.
How: each claim was checked by grep and reading the relevant module. Removed: the claims above. Corrected:
SecretCipher.kt), notEncryptedSharedPreferences; backup exclusion perdata_extraction_rules.xml.DefineViewModel), not an offline dictionary; "Offline Core" now says which features need a network key.Exporters.kt).PlaybackEngine.MAX_SPEED); sleep timer with shake-to-extend.ReaderStyle.kt).ChapterPack.kt; the real concept map (ConceptMapView) replaces "Book Map".OpenAudiobook/→Kepler/.README-only change; no code touched.
🤖 Generated with Claude Code
https://claude.ai/code/session_01DL7TMvGRPjugDQYxjpStjH
Generated by Claude Code