Repository navigation
Sample Gemma dialog turns as the model card recommends - #262
Conversation
A route can now set the sampling of its dialog turns: temperature, top_p, top_k, min_p, repeat_penalty and the two OpenAI penalties come from the merged model and assignment config, replace the provider's configured value field by field, and are ignored when out of range. The chat request gains min_p. Migration 208 sets the card values (temperature 0.6, top_p 0.9, top_k 64, min_p 0.05, repeat_penalty 1.1) on the dialog assignment of the GPU0 Gemma model only. The fallbacks and the other Gemma workflows keep their own sampling. NInfer clamps top_k to 20 candidates and the serving proxy drops repeat_penalty. The down migration restores the previous keys exactly.
The advisories published today fail the dependency gate for 0.23.45 (ECH rejection data leak, unbounded Brotli certificate allocation, ServerHello key-exchange downgrade, TLS secrets in Debug output). The lock file moves to the patched release; no manifest change is needed.
|
Danger migration warning: migration 208 only updates the The second commit moves |
Summary
temperature,top_p,top_k,min_p,repeat_penaltyand the two OpenAI penalties for its dialog turns. They come from the merged model and assignment config, the same waymax_tokensandbad_wordsalready do. Each value replaces the provider's configured value on its own; the rest keep their configured values. A value outside its valid range is ignored instead of failing the request. Before, the dialog path ignored the temperature and penalties of a route.min_pon the chat request. New optional field; it is sent only when a route sets it, and the direct VRAM Cloud request does not carry it.top_kto 20 candidates and the serving proxy dropsrepeat_penalty, so the effective changes are temperature 0.2 → 0.6, top_p 0.95 → 0.9 and min_p 0 → 0.05. The frequency (0.3) and presence (0.2) penalties stay.Migration notes
UPDATEof oneworkflow_assignmentsrow (workflowdialog, modelGemma 4 26B Hereticof provideraifarm-vllm-gpu0). It saves the previous value of each of the five keys undergemma_card_sampling_v1_previousand is idempotent. A database without that model is left unchanged.Checks
cargo fmt --allcargo clippy --workspace --all-targets -- -D warningscargo test -p openplotva-dialog -p openplotva-llm -p openplotva-storage -p openplotva-app