Fix adding notes to use absolute path#19
Open
cbreezier wants to merge 1 commit intoiangrunert:masterfrom
Open
Conversation
Relative path is ambiguously relative to current directory or git root
iangrunert
reviewed
Oct 6, 2016
| } | ||
|
|
||
| writenotes := exec.Command("git", "notes", "--ref="+ref, "add", "-f", "-F", notepath) | ||
| writenotes := exec.Command("git", "notes", "--ref="+ref, "add", "-f", "-F", filepath.Abs(notepath)) |
Owner
There was a problem hiding this comment.
store/git.go:52: multiple-value filepath.Abs() in single-value context
https://golang.org/pkg/path/filepath/#Abs
filepath.Abs() returns (string, error) -> you'll need to handle the potential error there before passing it through to the exec.Command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relative path is ambiguously relative to current directory or git root
When running
git notes add -Fit seems like the file is relative to git root rather than current directory. Maybe this is an issue with git, but we can be a bit more robust by using an absolute path