Fix CI Pipeline (E2E Test Issues)

[ianpaschal]

The E2E tests contained a flaky test.

Summary by CodeRabbit

• Tests
  • Updated tournament pairings test to dynamically derive table assignments from prior round data instead of hardcoded values, and enhanced test setup with manual pairing creation via drag-and-drop competitor placement.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
combat-command-app	Ready	Preview, Comment	Jun 11, 2026 11:26pm

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 63d8057b-ced4-40d8-8b5c-5b9c0c2a4858

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Walkthrough

This PR refactors the "Subsequent Round Flow" test in the tournament pairings test suite. The test now computes the expected table assignment option label dynamically from the prior round pairing data instead of hardcoding it. The test setup workflow changes from auto-generating pairings to manually adding pairing rows by dragging specific competitors into slots, which allows direct observation of repeat opponent and repeat table validation warnings. The test continues to verify color-coded error indicators and table assignment behavior across multiple pairings using the dynamically computed table option.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Fix CI Pipeline (E2E Test Issues)' accurately describes the pull request's primary objective of fixing flaky E2E tests in the CI pipeline.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ian/fix-ci-pipeline

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@test/tournament-pairings.spec.ts`:
- Line 269: The current assertion masks missing seed data by defaulting
completePairing.table to 0 when computing const table = ((completePairing.table
?? 0) + 1).toString(); instead fail fast: require completePairing.table to be
present before computing table (e.g., assert/expect completePairing.table is not
null/undefined or throw a clear error) and then compute table from the actual
value; update any test messages to reflect the explicit precondition check so
missing prior-round table data causes the test to fail rather than silently use
"1".

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: cd1d2680-7ede-4542-8b5b-35023a361652

📥 Commits

Reviewing files that changed from the base of the PR and between bc60a76 and 6e7def6.

📒 Files selected for processing (1)

• test/tournament-pairings.spec.ts