detect Magisk and surface provider on root status#10
Open
iboalali wants to merge 1 commit into
Open
Conversation
Replaces RootChecker's Boolean? return with a RootResult sealed type that carries the root provider (Magisk / Other / Unknown) and version when available. Magisk is detected via a combination of: - PackageManager probe for com.topjohnwu.magisk(.debug/.canary/.alpha) (gated by a new <queries> block in AndroidManifest) - /proc/self/mounts inspection (root-free) - magisk -V via libsu when root is granted - /data/adb/magisk and friends as a fallback When root is granted by Magisk, MainScreen now shows a secondary "via Magisk vX.Y" line under the existing status text. Other root providers fall back to the generic ROOTED display. Closes the "Magisk root check" TODO from the README. https://claude.ai/code/session_01NxY1tfQZxw6qwi41XkCWKa
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces RootChecker's Boolean? return with a RootResult sealed type
that carries the root provider (Magisk / Other / Unknown) and version
when available. Magisk is detected via a combination of:
(gated by a new block in AndroidManifest)
When root is granted by Magisk, MainScreen now shows a secondary
"via Magisk vX.Y" line under the existing status text. Other root
providers fall back to the generic ROOTED display.
Closes the "Magisk root check" TODO from the README.
https://claude.ai/code/session_01NxY1tfQZxw6qwi41XkCWKa